This repository was archived by the owner on Jan 19, 2023. It is now read-only.
Reset didUnmount flag when component is mounted #591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be awfully good & easy, compared to #632. Can you explain? |
|
This PR addresses a very specific bug in the library that manifests itself in React 18 strict mode. The other ticket you mention aims to address a completely different issue, so I’m not sure how to compare these two PRs. |
|
@igordanchenko no the other issue also fix #589. Is there anywhere can I read more about your fix? |
|
@nvmnghia, #632 doesn't fix the underlying issue described in #589, it's just hiding the most obvious symptom. In fact, #632 breaks the lightbox in React 18 strict mode as the lightbox can be opened only once, and won't open again once closed. You can read about React 18 strict mode component lifecycle changes here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in #589
Closes #589