Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check coverage at PR time #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kilianc
Copy link

@kilianc kilianc commented May 20, 2024

No description provided.

.github/workflows/main.yaml Outdated Show resolved Hide resolved
@joanlopez
Copy link
Member

Hey @kilianc,

Thanks for your contribution, I see you're trying to expand the use of your new project 😉
However, although I see how cool the tool is, I'm not really sure that we actually want to add such a detailed HTML view for coverage changes, as I feel like a simple comment in the PR would be more than enough.

Even in such case, I guess any widely used, free-to-use service for open-source projects like Codecov or Coveralls would probably be a better candidate, with all respects.

So, I'm not definitely rejecting it, but let's put it on hold, meanwhile I'll try to discuss it with @aperezg in order to move one with a formal and final decision.

That said, thanks anyway for bringing your proposals and for your contributions to this project! 🙌🏻

@kilianc
Copy link
Author

kilianc commented May 28, 2024

No offense taken! And please share any more feedback if don't find it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants