Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new config to dump the incoming requests #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pafuent
Copy link

@pafuent pafuent commented Jun 8, 2021

Adding a new configuration option per imposter to dump into the stdout the incoming requests.
This configuration could be override by a command line parameter, in which case all the imposter will log to stdout the incoming requested regardless their configuration.

Fixes #100

Adding a new configuration option per imposter to dump into the stdout
the incoming requests.
This configuration could be override by a command line parameter, in
which case all the imposter will log to stdout the incoming requested
regardless their configuration.
@pafuent
Copy link
Author

pafuent commented Jun 16, 2021

@aperezg, Could you please check this PR? Thanks!!!

Copy link
Member

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pafuent, sorry for the late reply. I've been OOO and I think @aperezg will be busy for a few more weeks.

I'd say the code looks quite good. However, I'd like to better understand what you're trying to solve with this approach because we discussed that in the past with @aperezg and we agreed that a (either single -v/--verbose or multiple -v, -vv, -vvv) verbose flag would be really helpful to better understand what's happening under the hood (incoming requests, outgoing responses, imposters matched, etc). Which, as fair as I understood, would cover what you suggested to add here.

So, what do you think about jumping into the issue you created (#100) and comment it? Thanks!! 😄

@joanlopez joanlopez mentioned this pull request Jul 1, 2021
@aperezg
Copy link
Member

aperezg commented Oct 12, 2021

hello @pafuent will you continue with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I would like to see the incoming requests dump into stdout
3 participants