Skip to content

Fix TypeError in number increment/decrement services when entity.value is string #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Draft

Fix TypeError in number increment/decrement services when entity.value is string #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ecbcb
Initial plan for issue
Copilot Jun 3, 2025
b2aa11d
Fix TypeError in number increment/decrement services when entity.valu…
Copilot Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion custom_components/spook/ectoplasms/number/services/decrement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ async def async_handle_service(
)
raise ValueError(msg)

value = entity.value - amount
value = float(entity.value) - amount

if entity.min_value is not None:
value = max(value, entity.min_value)
Expand Down
2 changes: 1 addition & 1 deletion custom_components/spook/ectoplasms/number/services/increment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ async def async_handle_service(
)
raise ValueError(msg)

value = entity.value + amount
value = float(entity.value) + amount

if entity.max_value is not None:
value = min(value, entity.max_value)
Expand Down