Skip to content

Add files via upload#1159

Open
razzietheman wants to merge 1 commit intofrenck:mainfrom
razzietheman:main
Open

Add files via upload#1159
razzietheman wants to merge 1 commit intofrenck:mainfrom
razzietheman:main

Conversation

@razzietheman
Copy link
Copy Markdown

correct sv.json

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

correct sv.json
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 5, 2026

📝 Walkthrough

Walkthrough

Swedish translation file updated with standardized terminology and grammar corrections for unknown-reference error messages across automations, integrations, groups, and related components. Translation keys realigned with consistent phrasing for areas, devices, entities, floors, labels, and services.

Changes

Cohort / File(s) Summary
Swedish Translation Updates
custom_components/spook/translations/sv.json
Comprehensive revision of unknown-reference error descriptions with standardized Swedish terminology. Updated entries for automation/device/entity/floor/label/service references; integration sources (Lovelace, proximity, scripts, utilities, trends); group members; and restart messaging. Replaced gender-specific phrasing with neutral terms, corrected grammar, and aligned descriptive text across all categories.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

maintenance

Suggested reviewers

  • frenck

Poem

🐰 Swedish words, so crisp and clean,
Translation polish, best you've seen,
From "områden" to "enheter" bright,
Grammar fixed from left to right,
Spook's Swedish now feels just right! ✨

Pre-merge checks

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Add files via upload' is vague and generic, failing to convey that this PR corrects Swedish translation strings in sv.json. Revise the title to be specific, such as 'Correct Swedish translations in sv.json for unknown-reference issues' to clearly indicate the purpose of the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description mentions 'correct sv.json' which relates to the changeset, despite being minimal and mostly template placeholders.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
custom_components/spook/translations/sv.json (1)

276-295: Minor inconsistency in title phrasing.

Lines 278 and 282 use "som används i" while lines 286, 290, and 294 use "används i" (without "som"). The automation section titles all use the shorter form "används i" consistently.

Both forms are grammatically correct, but for consistency across the file, consider aligning these titles.

🔎 Suggested alignment
     "script_unknown_area_references": {
       "description": "...",
-      "title": "Okända områden som används i: {script}"
+      "title": "Okända områden används i: {script}"
     },
     "script_unknown_device_references": {
       "description": "...",
-      "title": "Okända enheter som används i: {script}"
+      "title": "Okända enheter används i: {script}"
     },
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0043304 and 2e2035d.

📒 Files selected for processing (1)
  • custom_components/spook/translations/sv.json
🔇 Additional comments (4)
custom_components/spook/translations/sv.json (4)

224-247: LGTM!

The automation unknown reference translations are well-structured with consistent terminology:

  • Proper Swedish terms: områden, enheter, entiteter, våningsplan, etiketter, åtgärder
  • All placeholders correctly preserved
  • Consistent message structure across all variants

248-271: LGTM!

The translations for group, integration, Lovelace, and proximity sections are accurate with proper Swedish terminology and consistent structure.


296-307: LGTM!

The helper-related translations (Switch-as-X, utility meter, trend) are consistent and use proper Swedish terminology with all placeholders correctly preserved.


319-329: LGTM!

The restart confirmation message is clear and maintains the friendly Spook 👻 branding with proper Swedish grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant