Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: Add ffac-mt7915-hotfix #470

Merged
merged 1 commit into from
Sep 2, 2024
Merged

modules: Add ffac-mt7915-hotfix #470

merged 1 commit into from
Sep 2, 2024

Conversation

T0biii
Copy link
Member

@T0biii T0biii commented Aug 4, 2024

modules: Add ffac-mt7915-hotfix

closes #471

@T0biii T0biii requested review from maurerle and a team as code owners August 4, 2024 12:27
image-customization.lua Outdated Show resolved Hide resolved
image-customization.lua Outdated Show resolved Hide resolved
@T0biii T0biii added the next label Aug 5, 2024
@T0biii T0biii force-pushed the Add-ffac-mt7915-hotfix branch 2 times, most recently from 81e6b9c to 6b538c9 Compare August 11, 2024 12:11
@T0biii
Copy link
Member Author

T0biii commented Aug 11, 2024

mh konnte noch nicht herausfinden wieso der Build fehlschlägt bis jetzt habe ich nur folgendes im Log gefunden

2024-08-11T12:27:10.8549003Z Configuration failed:
2024-08-11T12:27:10.8549864Z  * unable to enable package 'ffac-mt7915-hotfix'

ah glaube für mt7622 geht es deswegen noch nicht: https://github.com/ffac/gluon-packages/blob/main/ffac-mt7915-hotfix/Makefile#L19

Edit:
neuer Build test für mt7622:

@T0biii
Copy link
Member Author

T0biii commented Aug 11, 2024

mh

2024-08-11T13:34:36.4736671Z cp: cannot create directory '/home/runner/work/site-ffm/site-ffm/gluon-build/openwrt/build_dir/target-aarch64_cortex-a53_musl/ffac-mt7915-hotfix/.pkgdir/ffac-mt7915-hotfix/usr': File exists
2024-08-11T13:34:36.4745557Z touch /home/runner/work/site-ffm/site-ffm/gluon-build/openwrt/build_dir/target-aarch64_cortex-a53_musl/ffac-mt7915-hotfix/.pkgdir/ffac-mt7915-hotfix.installed
2024-08-11T13:34:36.4750665Z     ERROR: package/feeds/ffac/ffac-mt7915-hotfix failed to build.

@T0biii
Copy link
Member Author

T0biii commented Aug 11, 2024

ok spannend für den mt7622 hat es anscheinend nun funktioniert: https://github.com/freifunkMUC/site-ffm/actions/runs/10339884021/job/28619803565
bei den anderen beiden nicht.

hat jemand noch eine weitere Idee wieso nicht?

@maurerle
Copy link
Collaborator

Die PKG_NAME variable war leider noch falsch:
ffac/gluon-packages@dd9252d und die Orte wo sie wiederverwendet wird wollen eben, dass diese übereinstimmen.

Sorry - das ist mir beim splitten des pakets wohl kaputt gegangen..

in mt7622 wird das paket einfach trotzdem nicht reingezogen:
https://github.com/ffac/gluon-packages/blob/dd9252d56aee2a753e93ce5a3775b3b80ad9592c/ffac-mt7915-reload/Makefile#L19 das müsste ich dafür dann noch anpassen.
Ich gucke erstmal ob es so jetzt läuft

@T0biii
Copy link
Member Author

T0biii commented Aug 12, 2024

@T0biii T0biii marked this pull request as draft August 12, 2024 18:27
@T0biii
Copy link
Member Author

T0biii commented Aug 13, 2024

gegen den PR ffac/gluon-packages#15 ist alles grün
image

Also wenn der gemergt wurde bumpe ich unser Module noch mal dann sollte dieser pr hier auch passen :)

@T0biii T0biii marked this pull request as ready for review August 23, 2024 15:44
@T0biii T0biii requested a review from grische August 31, 2024 18:09
@T0biii T0biii merged commit 66e5e31 into next Sep 2, 2024
32 checks passed
@T0biii T0biii deleted the Add-ffac-mt7915-hotfix branch September 2, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants