[BUGFIX] refresh hostname filter without observer#290
Merged
Conversation
maurerle
changed the title
maurerle
force-pushed
the
fix_input_value
branch
from
9f87e3e to
086ce80
Compare
maurerle
force-pushed
the
fix_input_value
branch
from
086ce80 to
300e7d5
Compare
Contributor
|
@maurerle any chance we can get a new release with that bug fix included? |
Contributor
|
@grische there's an open security issue to be fixed, we should wait for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in v13.0.0 a bug was introduced which loses focus when searching in the node bar.
This is due to the constant removal and readdition of the filter search bar.
The issue is fixed by not calling the notifyObservers for the hostname filter (which is needed to update the URL params).
fixes d45c19b
Description
Motivation and Context
How Has This Been Tested?
Screenshots/links:
Checklist: