Reduce surface & size of Cardinality #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitishr
changed the title
nitishr
force-pushed
the
simplify-cardinality
branch
3 times, most recently
from
bf6018b to
4215af3
Compare
Since times now accepts a required and a maximum number of calls, it can
replace at_{least,most}, reducing its API surface, which is internal
anyway.
... since times just delegated to update
This reverts commit 9d0d37a. 'times' expresses the responsibility of this method better, but had to be renamed earlier due to the introduction of a public method with the same name. That method is now gone, so we can revert to the original name.
nitishr
force-pushed
the
simplify-cardinality
branch
from
4215af3 to
0a7890e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and simplify cardinality setting methods of Expectation by delegating to times wherever possible