Skip to content

Conversation

@sanity
Copy link
Contributor

@sanity sanity commented Jan 27, 2025

…ract loading

@sanity sanity requested a review from iduartgomez April 2, 2025 16:01
@sanity sanity marked this pull request as ready for review April 2, 2025 16:03
@sanity
Copy link
Contributor Author

sanity commented Apr 2, 2025

@iduartgomez @netsirius It's a bit of a mish-mash of changes but I think this is ready to review however in order to make progress I had incorporated the changes from the add-subscribe-flag branch. I could back out those changes related to the new subscribe field but it would be a PITA so prefer to avoid. Thoughts?

@iduartgomez
Copy link
Contributor

@iduartgomez @netsirius It's a bit of a mish-mash of changes but I think this is ready to review however in order to make progress I had incorporated the changes from the add-subscribe-flag branch. I could back out those changes related to the new subscribe field but it would be a PITA so prefer to avoid. Thoughts?

No worries, just leave the changes in.

Will review asap.

@iduartgomez iduartgomez force-pushed the river-integration-modifications branch from c1e5648 to b675130 Compare April 6, 2025 08:55
@iduartgomez iduartgomez merged commit aed4d4c into main Apr 6, 2025
7 checks passed
@iduartgomez iduartgomez deleted the river-integration-modifications branch April 6, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants