Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete recommendations to mount fdescfs #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asomers
Copy link
Member

@asomers asomers commented Oct 9, 2024

fdescfs used to be useful to help Python more quickly close file descriptors before exec(). But for years, Python has been using closefrom() instead. All versions of Python 3.9 and later do that.

Fixes #39

Make sure to follow and check these boxes before submitting a PR! Thank you.

fdescfs used to be useful to help Python more quickly close file
descriptors before exec().  But for years, Python has been using
closefrom() instead.  All versions of Python 3.9 and later do that.

Fixes freebsd#39
@coveralls
Copy link

coveralls commented Oct 9, 2024

Pull Request Test Coverage Report for Build 11260497611

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 7.746%

Totals Coverage Status
Change from base Build 11083369461: 0.008%
Covered Lines: 798
Relevant Lines: 7796

💛 - Coveralls

@sporkman
Copy link

sporkman commented Oct 9, 2024

This is great, one more thing I don't have to modify on the host!

Slightly OT, but are there any ways to get a quicker output out of something like "iocage list"? That takes about 2.5 seconds (real 0m2.425s) which is just slow enough to be annoying. I tend to use "jls", but that doesn't show inactive jails, which in my environment can be a little misleading. It is fast though (real 0m0.002s).

@asomers
Copy link
Member Author

asomers commented Oct 9, 2024

This is great, one more thing I don't have to modify on the host!

Slightly OT, but are there any ways to get a quicker output out of something like "iocage list"? That takes about 2.5 seconds (real 0m2.425s) which is just slow enough to be annoying. I tend to use "jls", but that doesn't show inactive jails, which in my environment can be a little misleading. It is fast though (real 0m0.002s).

The only way I know of to speed up "iocage list" is to not use Python :( .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete recommendations to mount fdescfs
3 participants