-
-
Notifications
You must be signed in to change notification settings - Fork 11
fix: make it easier to make tags #435
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this!
There seems to be 2 issues:
- When no maching tags were found, it only shows the message "No options found!". Could you change it to something like "Add {new tag name}" so it's easier to find that the user can add a new tag?
- For example, if a tag
JavaScript
already exists, a new tagJava
can't be added.
I haven't tried it myself, but the AutoCompleteCreatable
component explained in this document seem to help:
https://www.npmjs.com/package/@choc-ui/chakra-autocomplete#creatable-items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue!
I haven't understood the whole code, but there appears to be problems:
- If there was an existing tag
JavaScript
and if you typeJava
, and then click "Create a tag named Java" in the select box, it doesn't create a new tag. - If there was an existing tag
JavaScript
and if you typeJava
, and then clickJavaScript
in the select box, it creates a new tagJava
instead.
It's working as I expected when there is no matching tag. It's easier to add new tags, so I'm sure the editors will appreciate it!
Hey @sidemt, I did not know it was possible to use your mouse to add or create new tags. Would you like me to add this functionality? I have only implemented creation/adding through the keyboard. Which should work as intended. |
closes #385