Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add a scroll to top button #999

Closed
wants to merge 3 commits into from
Closed

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Sep 23, 2024

Checklist:

Closes #634

It would be great if I could manage to make a test to ensure it's position is sticky, but this should be suitable enough for now.

Scroll to top button

@a2937 a2937 requested a review from a team as a code owner September 23, 2024 17:17
@a2937 a2937 changed the title Feat(UI)/scroll back to top feat(ui): add a scroll to top button Sep 23, 2024
@a2937 a2937 force-pushed the feat(UI)/scroll-back-to-top branch from 4f75ec4 to 5e5035a Compare October 8, 2024 19:20
@scissorsneedfoodtoo
Copy link
Contributor

Hi @a2937, thank you for your patience, and for all your hard work on this. This is off to a great start.

I'm getting some feedback from Quincy and others about whether we want to add a "Scroll to top" button or not, and if so, what sort of behavior and placement it should have.

Once I hear from everyone I can circle back and take another look at your PR.

@scissorsneedfoodtoo
Copy link
Contributor

Hi @a2937, thank you again for all of your hard work on this feature.

After talking with Quincy and the rest of the team, and seeing how most other tech blogs don't have a scroll to top button, we decided not to add this feature in for now.

Still, we'll listen for feedback from our readers, and if a lot of people ask for this we have a good start with your PR here.

As always, thank you for everything you're doing for the freeCodeCamp community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be a floating button for scrolling to top
2 participants