Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/test-ad-top #997

Merged
merged 4 commits into from
Sep 25, 2024
Merged

feat/test-ad-top #997

merged 4 commits into from
Sep 25, 2024

Conversation

ahmaxed
Copy link
Member

@ahmaxed ahmaxed commented Sep 23, 2024 •
edited
Loading

This should allow us to start testing the top banner ad.

Checklist:

Closes #XXXXX

@ahmaxed ahmaxed requested a review from a team as a code owner September 23, 2024 07:44
ahmaxed
ahmaxed commented Sep 23, 2024
View reviewed changes
.eleventy.js Outdated Show resolved Hide resolved
scissorsneedfoodtoo
scissorsneedfoodtoo approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything LGTM 👍

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit eaa8ea4 into main Sep 25, 2024
18 checks passed
@scissorsneedfoodtoo scissorsneedfoodtoo deleted the feat/test-ad-top branch September 25, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scissorsneedfoodtoo scissorsneedfoodtoo scissorsneedfoodtoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmaxed @scissorsneedfoodtoo @code-factor