Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add google tag manager script #993

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

ahmaxed
Copy link
Member

@ahmaxed ahmaxed commented Sep 17, 2024

Checklist:

Closes #XXXXX

@ahmaxed ahmaxed requested a review from a team as a code owner September 17, 2024 07:52
@ahmaxed
Copy link
Member Author

ahmaxed commented Sep 17, 2024

@scissorsneedfoodtoo, what would be the best way to only include these partials only when the site is in production?

@ahmaxed ahmaxed changed the title fix: add goole tag manager script fix: add google tag manager script Sep 17, 2024
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this waiting on?

@scissorsneedfoodtoo
Copy link
Contributor

@raisedadead, I'm taking a look at this now. A review should be up soon.

Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ahmaxed, thanks again for your patience.

Here's what we can do to only include these partials for production builds:

src/_includes/layouts/default.njk Outdated Show resolved Hide resolved
src/_includes/layouts/default.njk Outdated Show resolved Hide resolved
Co-authored-by: Kristofer Koishigawa <[email protected]>
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything LGTM 👍 👍

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit e78300d into main Sep 19, 2024
18 checks passed
@scissorsneedfoodtoo scissorsneedfoodtoo deleted the fix/add-gtm-script branch September 19, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants