Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update banner text when auth and donor #957

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Aug 15, 2024

Checklist:

Closes #689

It seemed like if a user was authenticated, they would see the authentication banner regardless if they were a donor. This should fix it.

@a2937 a2937 requested a review from a team as a code owner August 15, 2024 18:13
raisedadead
raisedadead previously approved these changes Aug 20, 2024
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably expand the tests?

@a2937
Copy link
Member Author

a2937 commented Aug 20, 2024

Yeah I'd like to expand the tests too. The biggest barrier to my expanding of the tests right this moment is a lack of intellisense in Visual Studio Code. It makes me feel better about the code I'm writing.

@a2937
Copy link
Member Author

a2937 commented Aug 21, 2024

It was a lot harder to write it without Typescript but it seems to have worked.

@raisedadead raisedadead merged commit 72bd4cb into main Aug 21, 2024
17 checks passed
@raisedadead raisedadead deleted the fix(ui)/update-banner-text branch August 21, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Donating users see the authenticated Banner instead
3 participants