Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing english builds #1082

Merged
merged 4 commits into from
Dec 15, 2024
Merged

fix: failing english builds #1082

merged 4 commits into from
Dec 15, 2024

Conversation

scissorsneedfoodtoo
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo commented Dec 15, 2024

Checklist:

This PR sets the timeout for Piscina explicitly to prevent parallel processing of posts / pages from timing out under the hood, and increases batch sizes for fetched posts / pages that are processed.

Edit: Tested and English builds do complete, but can be a bit flaky due to the way we fetch the trending.json files from the CDN.

By doing the following things we should fix the flakiness, and help bring more parts of the repo up-to-date:

  • Download trending.json before the builds similar to the way we do in the main repo
  • Require Node v20 in package.json and bump the versions in the GHA workflows (after testing with Ghost builds)
  • Cleanup Crowdin GHA so we can use Ubuntu 24.04 everywhere (remove Firefox downgrade step)

@scissorsneedfoodtoo scissorsneedfoodtoo marked this pull request as ready for review December 15, 2024 14:26
@scissorsneedfoodtoo scissorsneedfoodtoo requested a review from a team as a code owner December 15, 2024 14:26
@naomi-lgbt naomi-lgbt merged commit 90b134c into main Dec 15, 2024
18 checks passed
@naomi-lgbt naomi-lgbt deleted the fix/failing-english-builds branch December 15, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants