fix links to sections in the articles #1000
Conversation
|
Sorry about the noise with the bot. We will review these changes but we recommend you avoid editing code off of GitHub directly. |
src/_includes/assets/css/screen.css
Outdated
| @@ -171,7 +171,6 @@ body { | |||
| /* ---------------------------------------------------------- */ | |||
|
|
|||
| .site-nav { | |||
| z-index: 300; | |||
There was a problem hiding this comment.
| z-index: 300; | |
| z-index: 300; |
src/_includes/assets/css/screen.css
Outdated
| @@ -2209,7 +2208,6 @@ p.footer-donation a:hover { | |||
| .tags-row > .tag:hover { | |||
| background: var(--gray15); | |||
| color: var(--gray75); | |||
| color: var(--gray75); | |||
There was a problem hiding this comment.
| color: var(--gray75); | |
| color: var(--gray75); |
src/_includes/assets/css/screen.css
Outdated
| @@ -2240,7 +2238,6 @@ p.footer-donation a:hover { | |||
| button.cta-button, | |||
| a.cta-button { | |||
| width: content; | |||
| text-decoration: none; | |||
There was a problem hiding this comment.
| text-decoration: none; | |
| text-decoration: none; |
|
@naomi-lgbt yes, it was your bot that deleted some lines. |
|
@raisedadead how is adding commit from GitHub different from commit and push locally? |
Allow me to provide my own input. Generally speaking while adding a commit from GitHub is messier and doesn't provide an opportunity to test things locally. The number one rule when it comes to software development is to test early and often. You'll never know what kind of bugs might be present, and then there's still a chance you'll miss something. |
|
I can remove the commit the bot added and force push. I hope it will not delete that stuff again. |
|
@jcubic I have turned off the bot. Will you be OK to create a fresh PR? We recommend using GitPod or Codespaces if you prefer working on the browser. |
|
Created new PR #1010 |
Checklist:
This PR fixes annoying issue when you have Table of Contents and links with hash to section in the article. The scrollbar offset only take into account the header but ignored the banner that is below. I report it to editorial team, not sure if anyone created an issue for this. They said they want to get this fixed.
Update index.md)Closes #528