Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snowflake support #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

masch712
Copy link

Simply adding support for the Snowflake driver. I hope I added the dependency correectly.

Copy link

@nomeelnoj nomeelnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to send in my branch for this same change. Would love to see this merged!

@nomeelnoj
Copy link

Think we could get this merged soon? I would love to be able to use the official sql_exporter image rather than have to build from source and host my own...

@masch712
Copy link
Author

Hi @free, it sounds like there's at least two parties looking for this feature. Need anything else from me to facilitate reviewing this PR?

@nomeelnoj
Copy link

Hey @free! Any updates here? Would really love to be able to use the hosted sql_exporter image. Please let me know if there is anything you need from me to help get this pushed through and a new release cut!

@nomeelnoj
Copy link

Hey @free, @burningalchemist. It looks like maybe this repo is losing support, as it has not been updated in quite some time now. Is there anything we can do to help support it? I know this is a widely used tool in various locations, but we are in a place where im guessing most people are forking and managing their own, versus just using the open source version.

What can we do to get some of these PRs approved/merged?

@burningalchemist
Copy link
Contributor

burningalchemist commented Feb 25, 2021

Hey @nomeelnoj, you can take a look at the fork I maintain for the moment: https://github.com/burningalchemist/sql_exporter

It's compatible, has some updates, and I keep using it myself, so happy to look into the issues, if there are any.
It might be that at some point we can merge things back to the original repo, or maybe not. 🙂

If this works for you, give it a shot. 👍

@nomeelnoj
Copy link

@burningalchemist thanks! ill definitely take a look. Seems that the original maintainers of sql_exporter have gone MIA...sadly.

@burningalchemist
Copy link
Contributor

@nomeelnoj feel free to leave a comment, if there's an issue with it. 👍 I updated the latest snowflake driver version recently.

It's a bit tricky to test it with snowflake without creating an account, but I'm happy to look into it if anything. 🙂

@serratala
Copy link

why is this not merged? we are currently using it, and works as expected.

@jnovick
Copy link

jnovick commented Feb 18, 2024

Any update on this? Why has it not been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants