Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orcid auth plugin #183

Closed
wants to merge 3 commits into from
Closed

orcid auth plugin #183

wants to merge 3 commits into from

Conversation

c-ding-math
Copy link
Contributor

No description provided.

pbrisbin
pbrisbin reviewed May 24, 2024
View reviewed changes
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, can you apply the Restyled fixes? There are instructions in the build log if you click the details link on the failing PR status.

src/Yesod/Auth/OAuth2/ORCID.hs Outdated Show resolved Hide resolved
pbrisbin
pbrisbin requested changes May 24, 2024
View reviewed changes
src/Yesod/Auth/OAuth2/ORCID.hs Outdated Show resolved Hide resolved
@pbrisbin
Copy link
Member

pbrisbin commented Jul 8, 2024

Sorry I lost track of this. I'll see it over the line once #184 merges, so we can get that out in the next release.

@pbrisbin
Copy link
Member

pbrisbin commented Jul 8, 2024

Re-opened in #186, will go out with v0.7.3.0.

@pbrisbin pbrisbin closed this Jul 8, 2024
@pbrisbin pbrisbin mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrisbin pbrisbin pbrisbin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-ding-math @pbrisbin