always upload haddocks #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
reviewed
Sep 19, 2024
There was a problem hiding this comment.
I'm not necessarily against always uploading manual haddocks, but it is quite a long process. Moving to the include style seems pretty trivial to retain only doing it when needed. I drafted that here so you could see what it looks like: #198. If you agree, we can merge that one instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not getting
freckle-apphaddocks on Hackage because the libpq dependency is making it fail to compile. If #159 really is fixed then I don't see the harm in just always uploading the docs.