Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move freckle-app into a subdirectory #181

Merged
merged 1 commit into from
Jul 22, 2024
Merged

move freckle-app into a subdirectory #181

merged 1 commit into from
Jul 22, 2024

Conversation

chris-martin
Copy link
Contributor

@chris-martin chris-martin commented Jul 19, 2024

Same as with Blammo, I think this repository could make a good launching pad for smaller packages. It obviously won't be quite as cohesive as the Blammo repository because our starting point is not very cohesive. We should probably have ambitions to throw some packages outside the bounds of this repository. I envision this repo holding a collection of packages I believe @pbrisbin described that still aim to serve as Freckle's foundations and a normalizing force across the org, just split up a bit more granularly because e.g. a lot of the foundations of a web service differ from those of a command-line app, etc.

@chris-martin chris-martin requested a review from pbrisbin July 19, 2024 23:29
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of everything you say in the PR description, my only concern is pushing things into ./freckle-app before we have any concrete plan for sprouting even one other thing next to it. I worry it puts the repo into an unexpected state and ends up left like that for an extended time. Why do it now instead of waiting for a need to arise (and focusing our energies on defining it)?

@chris-martin
Copy link
Contributor Author

In my own projects I always start repositories with the package in a subdirectory even if there's only one, because... why not? I don't follow the "unexpected state" description, it seems perfectly ordinary.

@pbrisbin
Copy link
Member

In my own projects I always start repositories with the package in a subdirectory even if there's only one, because... why not?

It just seems like it introduces complexity for no gain. How tools handle a multi-package project changes. For example, a simple stack test is going to do the thing where the output is nested/prefixed because stack expects it to be multiple packages. You lose some minor things there like color, and error message readability. I imagine there are lots of little things like this, though this is the only one I can think of at the moment. I tend to ask why, not why not, I guess.

I don't follow the "unexpected state" description, it seems perfectly ordinary

Yeah, I guess "unexpected" is entirely subjective. It would be to me, but not to you. No idea what the rest of the team would expect or not.

@chris-martin
Copy link
Contributor Author

chris-martin commented Jul 22, 2024

A first step might be to do more or less the same concept as Blammo-wai. Create a new freckle-web package, move anything web-server-related into it?

@chris-martin chris-martin merged commit d6da576 into main Jul 22, 2024
7 checks passed
@chris-martin chris-martin deleted the chris/subdir branch July 22, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants