Fix DB metrics #141
Merged
Fix DB metrics #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
approved these changes
Jan 8, 2024
pbrisbin
requested changes
Jan 8, 2024
|
🤦 I'm sorry. I got notified of this PR being opened and thought it was a review-request. My notifications on freckle-app are a little aggressive. I now see you just opened a draft. Obviously, ignore me. |
joelmccracken
force-pushed
the
jnm/fix-db-metrics
branch
3 times, most recently
from
ab1069e to
fd4357f
Compare
joelmccracken
commented
Jan 10, 2024
Previously, the active_pool_connections metric was incremented _before_ the connection was obtained from the pool. This means that if there was a queue of requests awaiting connection availablity, the metric value would increase. The number of enqueued requests is still valuable to know though so we pick a metric with a better name (queries_enqueued_and_processing) and use it in the place of active_pool_connections, and we set active_pool_connections in another way which (I believe) will accurately capture this.
joelmccracken
force-pushed
the
jnm/fix-db-metrics
branch
from
fd4357f to
f7b2d69
Compare
pbrisbin
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
active_pool_connectionsqueries_enqueued_and_processingwhereactive_pool_connectionswas previously