Add WithLogger monad for deriving via #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-martin
force-pushed
the
chris/WithLogger
branch
from
4129016 to
d524cd9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- avoid bad use of withLoggerLoggingT - recommend WithLogger in the "use without LoggingT" section
This comment was marked as resolved.
This comment was marked as resolved.
chris-martin
commented
Jun 3, 2024
chris-martin
commented
Jun 3, 2024
pbrisbin
requested changes
Jun 3, 2024
stack-lts-13.0.yaml
Outdated
| resolver: lts-12.26 | ||
| resolver: lts-13.0 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pbrisbin
reviewed
Jun 3, 2024
| runLoggingT f $ \loc source level msg -> | ||
| runLogAction logger loc source level msg | ||
| runLoggerLoggingT env f = | ||
| runLoggingT f (runLogAction logger) `finally` flushLogStr logger |
There was a problem hiding this comment.
Oooo, I like how this un-sectioned the finally 🤩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler replacement for #43. This is just a minor version bump now since it's only additions.