Skip to content

Commit

Permalink
Improve function calls (#11)
Browse files Browse the repository at this point in the history
* Update RussianToEnglish.php
* Update UkrainianToEnglish.php
  • Loading branch information
fre5h committed Nov 11, 2017
1 parent 988710f commit 109238c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions src/RussianToEnglish.php
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ public static function transliterate(string $russianText): string
{
$transliteratedText = '';

if (mb_strlen($russianText) > 0) {
$transliteratedText = str_replace(
array_keys(self::$russianToEnglishRules),
array_values(self::$russianToEnglishRules),
if (\mb_strlen($russianText) > 0) {
$transliteratedText = \str_replace(
\array_keys(self::$russianToEnglishRules),
\array_values(self::$russianToEnglishRules),
$russianText
);
}
Expand Down
12 changes: 6 additions & 6 deletions src/UkrainianToEnglish.php
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,13 @@ public static function transliterate(string $ukrainianText): string
{
$transliteratedText = '';

if (mb_strlen($ukrainianText) > 0) {
if (\mb_strlen($ukrainianText) > 0) {
if (self::checkForZghException($ukrainianText)) {
$ukrainianText = str_replace(['Зг', 'зг'], ['Zgh', 'zgh'], $ukrainianText);
$ukrainianText = \str_replace(['Зг', 'зг'], ['Zgh', 'zgh'], $ukrainianText);
}
$transliteratedText = str_replace(
array_keys(self::$ukrainianToEnglishRules),
array_values(self::$ukrainianToEnglishRules),
$transliteratedText = \str_replace(
\array_keys(self::$ukrainianToEnglishRules),
\array_values(self::$ukrainianToEnglishRules),
$ukrainianText
);
}
Expand All @@ -125,6 +125,6 @@ public static function transliterate(string $ukrainianText): string
*/
private static function checkForZghException(string $ukrainianText): bool
{
return (bool) mb_substr_count($ukrainianText, 'Зг') || (bool) mb_substr_count($ukrainianText, 'зг');
return (bool) \mb_substr_count($ukrainianText, 'Зг') || (bool) \mb_substr_count($ukrainianText, 'зг');
}
}

0 comments on commit 109238c

Please sign in to comment.