[#533] code review #535
Merged
[#533] code review #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattD8957
added
cleanup
Closed
WindowsVistaisCool
approved these changes
Apr 12, 2024
| @@ -25,5 +25,6 @@ | |||
| } | |||
| }, | |||
| ], | |||
| "java.test.defaultConfig": "WPIlibUnitTests" | |||
| "java.test.defaultConfig": "WPIlibUnitTests", | |||
| "java.format.settings.url": ".vscode/eclipse-java-google-style.xml" | |||
There was a problem hiding this comment.
this should be set to .github/sun_checks.xml
There was a problem hiding this comment.
@WindowsVistaisCool You need to change the online version then, because this is the fix for redhat formatter
|
I'm still cleaning, also the LED thing got fixed. It needs to be that or you need to change the one online because those settings are the ones that make the formater funny. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #533