Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

99 shoot system tests #129

Merged
merged 6 commits into from
Jan 29, 2024
Merged

99 shoot system tests #129

merged 6 commits into from
Jan 29, 2024

Conversation

Swordpartee
Copy link
Contributor

Closes #99

@Swordpartee Swordpartee added shooter Code related to shooting indexer Code related to the indexer system tests Related to system tests labels Jan 29, 2024
@Swordpartee Swordpartee added this to the Week 0 milestone Jan 29, 2024
@Swordpartee Swordpartee requested a review from a team January 29, 2024 23:35
@Swordpartee Swordpartee self-assigned this Jan 29, 2024
@Swordpartee Swordpartee linked an issue Jan 29, 2024 that may be closed by this pull request
System test for shooter #99
Closed
HeeistHo
HeeistHo requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@HeeistHo HeeistHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the collector stuff from the system test, it should be it's own system test

HeeistHo
HeeistHo approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@HeeistHo HeeistHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wowie the code is code 👍

@HeeistHo HeeistHo merged commit f0411b4 into main Jan 29, 2024
5 checks passed
@HeeistHo HeeistHo deleted the 99-shoot-system-tests branch January 29, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeeistHo HeeistHo HeeistHo approved these changes

Assignees

@Swordpartee Swordpartee

Labels
indexer Code related to the indexer shooter Code related to shooting system tests Related to system tests
Projects
None yet
Milestone
Week 0
Development

Successfully merging this pull request may close these issues.

System test for shooter
4 participants
@Swordpartee @HeeistHo @MattD8957 @WindowsVistaisCool