Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the timestamp now stored in Pose4d (be sure and update Thunder first) #109

Merged
merged 4 commits into from
Jan 27, 2024

Conversation

phurley
Copy link
Contributor

@phurley phurley commented Jan 26, 2024

Really simple change to use the timestamped Pose4d to ensure we get the right poses and their timestamps.

Note after testing we may want to add a computation offset, but I hope this is going to be a big improvement.

@MattD8957
Copy link
Contributor

Closes #110

@MattD8957 MattD8957 linked an issue Jan 27, 2024 that may be closed by this pull request
@MattD8957 MattD8957 added this to the Week 0 milestone Jan 27, 2024
@MattD8957 MattD8957 added bug Something isn't working drivetrain Code related to the drivetrain labels Jan 27, 2024
Copy link
Contributor

@MattD8957 MattD8957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattD8957 MattD8957 merged commit 0b64990 into main Jan 27, 2024
3 of 5 checks passed
@MattD8957 MattD8957 deleted the use-timestamped-pose branch January 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working drivetrain Code related to the drivetrain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pose estimator timestamp
3 participants