Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvments about Gantt #397

Closed
wants to merge 7 commits into from
Closed

Improvments about Gantt #397

wants to merge 7 commits into from

Conversation

gdebrion
Copy link

Hello,

I noticed an error on Firefox and Chrome with the selectors #${id}-highlight. CSS selectors can not start with a digit, so I just reversed the name.

@gdebrion gdebrion changed the title Patch highlight date selector Improvments about Gantt May 28, 2024
@gdebrion
Copy link
Author

Sorry I didn't know that all commits to my master branch will be added to this merge request.
So, some improvments:

  • The tooltip was not centered correctly on Firefox ;
  • There is a typo in the call of upper_text function ;
  • Someone add code to add shortened months but forgot that everybody doesn't want english 😄

safwansamsudeen added a commit to safwansamsudeen/gantt that referenced this pull request Sep 11, 2024
@safwansamsudeen
Copy link
Collaborator

safwansamsudeen commented Sep 11, 2024

Thank you! Some of these are fixed in #423. Having popups at the place of entry is intentional.

What does the last commit do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants