Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply prettier formatting on all files #395

Closed
wants to merge 1 commit into from

Conversation

jledentu
Copy link

@jledentu jledentu commented May 3, 2024

Hi!

Prettier is used to format files. But I noticed that the formatting was not actually applied on all files. This PR fixes that. This will avoid to have other Pull Requests polluted by large re-formats.

As explained in the Prettier documentation, it's recommended to set formatted files with .prettierignore rather than a file glob in prettier command:

It’s recommended to have a .prettierignore in your project! This way you can run prettier --write . to make sure that everything is formatted (without mangling files you don’t want, or choking on generated files). And – your editor will know which files not to format!

So I changed the prettier and prettier-check scripts to apply formatting on all files!

@safwansamsudeen
Copy link
Collaborator

Hi, we're totally revamping our tooling in #394, so this file structure no longer applies.

@jledentu
Copy link
Author

jledentu commented May 3, 2024

Hi, we're totally revamping our tooling in #394, so this file structure no longer applies.

@safwansamsudeen Yeah, but your PR mixes formatting, bug fixes and tooling evolutions, and these distinct changes are not dependent to each other. I think you should split this work in several separate PRs. 😉 That's why I submit this PR which is totally independent to future upgrade to Vite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants