fix: correctly change from and to amount during cross currency Payment Entry (Internal Transfer) #45620
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h different currencies
|
This change doesn't work. Also, let's not add this behavior. There are scenarios where users want to book certain amount under Deductions and the current behavior allows it. With proposed changes, Paid and Received amount will always be in sync and it won't be possible to book deductions |
|
Maybe at least change it for the first time, when Received Amount is set? For example if Received Amount was 0, then gets set to 100, and Target Exchange Rate is 1.05, then Paid Amount becomes 105, but if Received or Paid amount is changed again, they will not be in sync 2025-02-04.16-13-13.mp4 |
This can be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue #45543
Previous behaviour: From and To amounts for Internal Transfer Payment Entries were not being updated when any of the 3 values (3rd being Exchange Rate) were being modified.
New behaviour: To system will now auto compute from and to amounts based on other 2 fields and exchange rate
no-docs