Missing dependencies #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added react and react-dom to package-json.
|
Hi there! Thanks for contributing. Cannot test this right now but those deps should be transitive deps of run-js, can you double check? |
|
When I tried running your repo on CodeSandbox. It threw an error while trying to resolve react. It still works without run-js in package-json. |
|
Im not familiar with CodeSandbox, please check in your local machine.
It is weird that it works without run-js since its the main runner of the
code so please double check by removing node modules and re installing
everything from scratch
…On Sun, Jul 22, 2018, 13:30 Anuraag Gupta ***@***.***> wrote:
When I tried running your repo on CodeSandbox. It threw an error while
trying to resolve react.
https://codesandbox.io/s/mqoznjyjv9
It still works without run-js in package-json.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABxEJ8rFvNh60WV2DeXyJEvSPRCgQkIKks5uJKi2gaJpZM4VaCDA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added react and react-dom to package-json. Don't know why they were missing in the first place