Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read socket rework #35

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Read socket rework #35

merged 8 commits into from
Dec 31, 2024

Conversation

franklee26
Copy link
Owner

@franklee26 franklee26 commented Dec 18, 2024

my_server
client_sender

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 59.37500% with 182 lines in your changes missing coverage. Please review.

Project coverage is 79.47%. Comparing base (3424b6f) to head (918f7f2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/worker/writer.rs 72.72% 48 Missing ⚠️
src/bin/server.rs 0.00% 47 Missing ⚠️
src/bin/client.rs 0.00% 40 Missing ⚠️
src/worker/conn_reader.rs 66.34% 35 Missing ⚠️
src/core/packet.rs 0.00% 8 Missing ⚠️
src/net/connection.rs 91.66% 2 Missing ⚠️
src/worker/reader.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
+ Coverage   51.14%   79.47%   +28.33%     
===========================================
  Files          17       17               
  Lines        3930     2027     -1903     
===========================================
- Hits         2010     1611      -399     
+ Misses       1920      416     -1504     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franklee26 franklee26 merged commit 5fc3314 into main Dec 31, 2024
6 checks passed
@franklee26 franklee26 deleted the read-socket-rework branch December 31, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant