Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ack-handling part #2 #32

Merged
merged 13 commits into from
Nov 27, 2024
Merged

Ack-handling part #2 #32

merged 13 commits into from
Nov 27, 2024

Conversation

franklee26
Copy link
Owner

No description provided.

@franklee26 franklee26 self-assigned this Nov 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 89.70060% with 86 lines in your changes missing coverage. Please review.

Project coverage is 49.02%. Comparing base (ddd9331) to head (9365890).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/bin/server.rs 0.00% 32 Missing ⚠️
src/worker/writer.rs 93.82% 16 Missing ⚠️
src/worker/reader.rs 87.09% 12 Missing ⚠️
src/bin/client.rs 0.00% 9 Missing ⚠️
src/core/packet.rs 97.26% 4 Missing ⚠️
src/net/connection.rs 87.50% 4 Missing ⚠️
src/net/server.rs 92.15% 4 Missing ⚠️
src/net/ordered_bytes.rs 92.68% 3 Missing ⚠️
src/net/ack_handler.rs 95.91% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #32       +/-   ##
===========================================
- Coverage   78.33%   49.02%   -29.31%     
===========================================
  Files          14       17        +3     
  Lines        1186     3786     +2600     
===========================================
+ Hits          929     1856      +927     
- Misses        257     1930     +1673     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franklee26 franklee26 merged commit c326637 into main Nov 27, 2024
5 of 6 checks passed
@franklee26 franklee26 deleted the ack-handling-part-2 branch November 27, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants