New frontend UX design #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
philipsens
reviewed
Dec 13, 2024
philipsens
reviewed
Dec 13, 2024
| </nav> | ||
| <div class="actions"> | ||
| <button class="switch-theme-button" title="Dark/light Mode"> | ||
| <app-icon-darkmode width="20" height="20" colour="#8A8A8A"></app-icon-darkmode> |
There was a problem hiding this comment.
It might be smart to create vars for colors, to make then reusable and easy to change.
This would also apply to the colors in the CSS itself.
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry, this link is not really explaining what I mend. I mend to do it like this:
body {
--my-color: #fdc300;
}<component color="var(--my-color)" />
<div [attr.fill]="color" />
philipsens
reviewed
Dec 13, 2024
frank-doc-frontend/src/app/components/javadoc-transform.directive.ts
Outdated
Show resolved
Hide resolved
frank-doc-frontend/src/app/views/details/details-element/details-element.component.ts
Outdated
Show resolved
Hide resolved
frank-doc-frontend/src/app/views/home/home-component-list/home-component-list.component.html
Outdated
Show resolved
Hide resolved
frank-doc-frontend/src/app/views/home/home-component-list/home-component-list.component.html
Outdated
Show resolved
Hide resolved
frank-doc-frontend/src/app/views/home/home-filters/home-filters.component.html
Outdated
Show resolved
Hide resolved
frank-doc-frontend/src/app/views/home/home-filters/init-filter-toggle.directive.ts
Outdated
Show resolved
Hide resolved
frank-doc-frontend/src/app/views/details/details-element/details-element.component.html
Outdated
Show resolved
Hide resolved
Matthbo
force-pushed
the
235-implement-new-frontend-design-frankdoc-format
branch
from
cc6bdca to
b3f7f28
Compare
philipsens
reviewed
Dec 18, 2024
philipsens
reviewed
Dec 19, 2024
|
|
||
| collapseElement(): void { | ||
| this.collapse.classList.add('transforming'); | ||
| this.collapseAnimation = this.collapse.animate({ height: [`${this.clientHeight}px`, '0px'] }, this.animationSpeed); |
| ignoreLocation: true, | ||
| }; | ||
|
|
||
| export const filterColours: string[] = ['#CD55EB', '#037CD4', '#00B31D']; |
philipsens
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the FF!Reference design guide & angular components library