Fix value substitution for parameters and forwards #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ik heb de unit testen geüpdated, maar ik heb niet de Frank!Doc outputs voor en na deze fix vergeleken, dus de resultaten als de doclet wordt toegepast op de FF! code. Laat maar horen als je denkt dat dit nodig is. |
nielsm5
reviewed
Jul 1, 2024
| * @ff.forward {@value #MY_CONSTANT} Forward description {@value #MY_CONSTANT} | ||
| */ | ||
| public class WithValueSubstitutions { | ||
| public static final String MY_CONSTANT = "my-constant"; |
There was a problem hiding this comment.
Je hebt nu alleen testen voor substutions binnen de zelfde class. Misschien dat je ook nog een testje zou kunnen maken van een andere class (duplicaat hiervan) die verwijst naar MY_CONSTANT.
nielsm5
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.