Move to Java 17 and higher #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
============================================
- Coverage 84.33% 84.31% -0.02%
Complexity 1390 1390
============================================
Files 79 79
Lines 4456 4457 +1
Branches 523 523
============================================
Hits 3758 3758
- Misses 564 565 +1
Partials 134 134 ☔ View full report in Codecov by Sentry. |
nielsm5
reviewed
Feb 21, 2024
| @@ -54,6 +54,7 @@ class Doclet { | |||
| FrankElementFilters.getExcludeFilter(), FrankElementFilters.getExcludeFiltersForSuperclass()); | |||
|
|
|||
| model = FrankDocModel.populate(options.getDigesterRulesUrl(), options.getRootClass(), repository); | |||
| log.info("Found classes: {}", repository.size()); | |||
There was a problem hiding this comment.
Suggested change
| log.info("Found classes: {}", repository.size()); | |
| log.info("Found classes: {}", repository::size); |
There was a problem hiding this comment.
If I do that, I get the warning: 'org.apache.logging.log4j.util.Supplier' is deprecated, so I'll leave it for now.
frank-doc-doclet/src/test/java/org/frankframework/frankdoc/testdoclet/EasyDoclet.java
Outdated
Show resolved
Hide resolved
frank-doc-doclet/src/test/java/org/frankframework/frankdoc/testdoclet/EasyDoclet.java
Show resolved
Hide resolved
nielsm5
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored mechanism how the EasyDoclet in the unittests was used. Now it uses less internals of the JVM, but uses the
Startclass of the Javadoc tools. The same tools are used by the Javadoc binary itself, so it is more future proof.Secondly, bumped a lot of plugins used and deps were available.