Fix compilation with Poco >= 1.12 #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasKuhner
force-pushed
the
main
branch
3 times, most recently
from
a99d195 to
182c9c4
Compare
kmohyeldin
force-pushed
the
main
branch
3 times, most recently
from
0b3fa66 to
06bba4e
Compare
AndreasKuhner
force-pushed
the
main
branch
3 times, most recently
from
ad6f82d to
b909130
Compare
kmohyeldin
force-pushed
the
main
branch
5 times, most recently
from
be4a682 to
e4b1f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Poco 1.12, the
DatagramSocketconstructorDatagramSocket(const SocketAddress& addr, bool reuseAddress=false)was changed, and there default value of thereuseAddresswas removed, so to ensure compilation with Poco >= 1.12, it is necessary to explicitly set thereuseAddressargument. As before the second argument already existed, the change is backward compatible.See pothosware/PothosCore#241 for a similar issue.