Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev chart zone #1520

Open
wants to merge 8 commits into
base: dev-chart-zone
Choose a base branch
from

Conversation

Kiruthick-Roxx
Copy link

Option to configure zones for both fill and stroke with individual zone arrays. Also added a function to dynamically change the tooltip marker color based on the tagvalue at that time period.

@unocelli
Copy link
Member

unocelli commented Dec 7, 2024

Hi, good work but I have a question, why do you separate stroke and fill into two lists? fill is also associated with a line like stroke, I would simply add the fill attribute to ChartLineZone

@Kiruthick-Roxx
Copy link
Author

Hi,
The problem is, when the color attribute is applied to both stroke and fill, while plotting, the graph looks weird and it becomes difficult to differentiate when 2 or more tags are added for a single chart. By, applying different color, it is possible to give a transparent fill or a fill with reduced transparency. This might give a good look for the chart.

@unocelli
Copy link
Member

Hi, I intend to add the attribute fill in ChartLineZone

export interface ChartLineZone {
    min: number;
    max: number;
    color: string;
    fill: string;
}

image

@Kiruthick-Roxx
Copy link
Author

Hi,
That's really great. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants