-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes found when running experiments #1
base: refactor_development_bug_halt
Are you sure you want to change the base?
Bug fixes found when running experiments #1
Conversation
ravinkohli
commented
Apr 1, 2021
- Moved to warn user not error for unexpected update
"This update {} will be removed".format(node.__class__.__name__, | ||
components.keys(), choice, update), | ||
UserWarning) | ||
self.search_space_updates.updates.remove(update) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you call the remove outside of the foreach loop? Like I don't think it is a good idea to update the list while iterating on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I'll do so
"This update {} will be removed".format(node.__class__.__name__, | ||
components.keys(), split_hyperparameter[0], | ||
update), UserWarning) | ||
self.search_space_updates.updates.remove(update) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
if split_hyperparameter[1] not in component. \ | ||
get_hyperparameter_search_space(dataset_properties=self.dataset_properties): | ||
if split_hyperparameter[1] not in \ | ||
component.get_hyperparameter_search_space(dataset_properties=self.dataset_properties): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put the new line after the parenthesis?
component.get_hyperparameter_search_space( | ||
dataset_properties=self.dataset_properties).get_hyperparameter_names(), | ||
split_hyperparameter[1], update), UserWarning) | ||
self.search_space_updates.updates.remove(update) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
if update.hyperparameter not in node.get_hyperparameter_search_space( | ||
dataset_properties=self.dataset_properties): | ||
if update.hyperparameter not in \ | ||
node.get_hyperparameter_search_space(dataset_properties=self.dataset_properties): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here