Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HRIS - 430] - [Bugtask] Double Status Shown in Notification Modal for Change Shift Request #329

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jessrey-asterisk
Copy link

@jessrey-asterisk jessrey-asterisk commented Oct 30, 2024

Issue Link

https://framgiaph.backlog.com/view/HRIS-430

Definition of Done

  • Only one text for "Status" display should be seen which is the one under the RequestStatusChip component

Pre-condition

Run 'npm run dev' on client
Run 'dotnet run' on api

Expected Output

It should display only 1 text in the status area where it is formatted in the component for all conditions "Pending", "Approved", "Disapproved"

Screenshots/Recordings

For Pending:
image

For Approved
image

For Disapproved
image

@jessrey-asterisk jessrey-asterisk changed the title Double Status Shown in Notification Modal for Change Shift Request [HRIS - 430] - [Bugtask] Double Status Shown in Notification Modal for Change Shift Request Oct 31, 2024
Copy link

@JohnlynDC JohnlynDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

  • It only displays one text on the status for all conditions "Pending", "Approved", and "Disapproved"

For Pending
Screenshot 2024-11-06 154049

For Approved
Screenshot 2024-11-06 155014

For Disapproved
Screenshot 2024-11-06 155038

Comments: 0
Testing Time: 20 mins
Iterations: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants