Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HRIS-334 [FE] Integrate Request new schedule tab #295

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

HRIS-334 [FE] Integrate Request new schedule tab #295

wants to merge 1 commit into from

Conversation

jsvelte
Copy link
Contributor

@jsvelte jsvelte commented Jul 10, 2023 •
edited
Loading

Issue Link

Definition of Done

  • Add Team Leader Multi Select Dropdown field during submitting
  • Team Leader will be have Realtime notified after the request submitted
  • Added View details Modal in Notification Page of the Requested Schedule

Notes

Pre-condition

Docker

run docker compose up --build

Local

  • run cd client && npm run dev
  • run cd api && dotnet watch
  • go to the /my-schedule/request-new-schedule

Expected Output

  • User should now able to request a new schedule
  • If you are a team leader selected during request you will be notified by the request

Screenshots/Recordings

Sun_.HRIS.-.Request.New.Schedule.webm

@jsvelte jsvelte requested a review from NiloJr-sun July 10, 2023 10:07
@jsvelte jsvelte self-assigned this Jul 10, 2023
@jsvelte jsvelte force-pushed the feature/hris-334 branch 6 times, most recently from 89f2f54 to 2fd89a1 Compare July 11, 2023 06:10
@jsvelte jsvelte marked this pull request as ready for review July 11, 2023 06:11
arden-dave-sun
arden-dave-sun approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@arden-dave-sun arden-dave-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arden-dave-sun arden-dave-sun arden-dave-sun approved these changes

@NiloJr-sun NiloJr-sun Awaiting requested review from NiloJr-sun

Assignees

@jsvelte jsvelte

Labels
For Code Review 💻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsvelte @arden-dave-sun @acatzk