Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HRIS-336 [FE] Integrate Filed Schedules tab in My schedule page #294

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

HRIS-336 [FE] Integrate Filed Schedules tab in My schedule page #294

wants to merge 1 commit into from

Conversation

NiloJr-sun
Copy link
Contributor

Issue Link

Definition of Done

  • Users can view their filed schedule requests

Notes

  • None

Pre-condition

  • Running BE and FE

Expected Output

  • In the http://localhost:3000/my-schedule/filed-schedules it should reflect your filed schedule requests

Screenshots/Recordings

chrome_2TvnIpgwAx.mp4

@NiloJr-sun NiloJr-sun self-assigned this Jul 10, 2023
@NiloJr-sun NiloJr-sun force-pushed the feature/hris-336 branch 3 times, most recently from 8d2f14e to 32df876 Compare July 10, 2023 07:28
jsvelte
jsvelte approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@jsvelte jsvelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 💯

jsvelte
jsvelte reviewed Jul 11, 2023
View reviewed changes
client/src/pages/my-schedule/filed-schedules.tsx
const mappedOffsets = getFiledScheduleRequestMappedData()
setFiledRequestDataTable(mappedOffsets)
}
}, [FiledSchedule])

if (process.env.NEXT_PUBLIC_DISPLAY_MY_SCHEDULE_PAGE === 'false') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

jsvelte
jsvelte reviewed Jul 11, 2023
View reviewed changes
client/src/utils/constants/dummyMyFiledScheduleData.ts
@@ -2,352 +2,9 @@ import { IMyFiledScheduleData } from '../interfaces'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all of this data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvelte jsvelte jsvelte approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@NiloJr-sun NiloJr-sun

Labels
For Code Review 💻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiloJr-sun @jsvelte