DECISIONS.md read against the code twice; what was cut too far goes back, what was unstated goes to SPEC.md - #1763
Open
suleimansh wants to merge 1 commit into
Open
DECISIONS.md read against the code twice; what was cut too far goes back, what was unstated goes to SPEC.md#1763suleimansh wants to merge 1 commit into
suleimansh wants to merge 1 commit into
Conversation
…ack, what was unstated goes to SPEC.md Rom's header clause "Keep outdated decisions (no history)". Five clauses the #1760 cut dropped are restored, four phrases widened to match the code, ten wording fixes, and fifteen sentences added to SPEC.md files for behaviour stated nowhere. Bug found on the way: #1762. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LnZR6mRrKS1fB5GoJrkSGX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three DECISIONS.md files read against their code, twice, by a fresh reader per package that saw only that package. What the reads changed:
The header takes one clause from upstream: "Keep outdated decisions (no history)."
Five clauses go back in. The #1760 cut dropped them, and without them the file disagrees with the code or the skill text: the session name's leading character, the checkout's own branch not counting as taken,
statustaking a path, dependencies linked two levels deep, and the library's own commit messages. One sentence the cut had reworded, "parent directories are created", was true of the test seam only and is gone.Four phrases were narrower than the code. A rebase that fails for any reason resets to origin, not only a conflict. Any rejected push re-runs the write, not only a lost race. A ticket's
Priority:is lowercased, not verbatim. The summary scan stops at the head a list reads, not the end of the file.Ten small wording fixes. A missing subject, a term used before it is introduced,
puttakingmeta.jsonas well,attachtaking the caller's branch as given.Fifteen sentences added to SPEC.md files, not to DECISIONS.md, for behaviour the readers found in neither: the 4,000-byte head a list reads, the
Source:line never being a summary,closerefusing on a detached checkout, reads not waiting for the write lock, the whole-repository worktree prune, the 16 MB output cap, the lock keyed by the path as spelled, the detached write raising everything but a missing remote, a ticket with no heading losing its keys,releasenever reading the ticket, a pull URL counting as an issue reference, same-day tickets in filename order, a detached checkout'sonRemote, the branches a removal reports as deleted, a forced removal that fails, and.binas one linked entry.One bug found on the way is #1762.
🤖 curated · Fable 5.1, effort high