Skip to content

DECISIONS.md read against the code twice; what was cut too far goes back, what was unstated goes to SPEC.md - #1763

Open
suleimansh wants to merge 1 commit into
mainfrom
decisions-read
Open

DECISIONS.md read against the code twice; what was cut too far goes back, what was unstated goes to SPEC.md#1763
suleimansh wants to merge 1 commit into
mainfrom
decisions-read

Conversation

@suleimansh

Copy link
Copy Markdown
Contributor

The three DECISIONS.md files read against their code, twice, by a fresh reader per package that saw only that package. What the reads changed:

The header takes one clause from upstream: "Keep outdated decisions (no history)."

Five clauses go back in. The #1760 cut dropped them, and without them the file disagrees with the code or the skill text: the session name's leading character, the checkout's own branch not counting as taken, status taking a path, dependencies linked two levels deep, and the library's own commit messages. One sentence the cut had reworded, "parent directories are created", was true of the test seam only and is gone.

Four phrases were narrower than the code. A rebase that fails for any reason resets to origin, not only a conflict. Any rejected push re-runs the write, not only a lost race. A ticket's Priority: is lowercased, not verbatim. The summary scan stops at the head a list reads, not the end of the file.

Ten small wording fixes. A missing subject, a term used before it is introduced, put taking meta.json as well, attach taking the caller's branch as given.

Fifteen sentences added to SPEC.md files, not to DECISIONS.md, for behaviour the readers found in neither: the 4,000-byte head a list reads, the Source: line never being a summary, close refusing on a detached checkout, reads not waiting for the write lock, the whole-repository worktree prune, the 16 MB output cap, the lock keyed by the path as spelled, the detached write raising everything but a missing remote, a ticket with no heading losing its keys, release never reading the ticket, a pull URL counting as an issue reference, same-day tickets in filename order, a detached checkout's onRemote, the branches a removal reports as deleted, a forced removal that fails, and .bin as one linked entry.

One bug found on the way is #1762.

🤖 curated · Fable 5.1, effort high

…ack, what was unstated goes to SPEC.md

Rom's header clause "Keep outdated decisions (no history)". Five clauses the #1760
cut dropped are restored, four phrases widened to match the code, ten wording
fixes, and fifteen sentences added to SPEC.md files for behaviour stated nowhere.
Bug found on the way: #1762.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LnZR6mRrKS1fB5GoJrkSGX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant