Skip to content

Dogfood 2026-09-05: npx tickets resolves locally, CLI tests drop the daemon's AGENT_ID, two SKILL.md phrases - #1759

Merged
suleimansh merged 1 commit into
mainfrom
dogfood-0905-fixes
Sep 7, 2026
Merged

Dogfood 2026-09-05: npx tickets resolves locally, CLI tests drop the daemon's AGENT_ID, two SKILL.md phrases#1759
suleimansh merged 1 commit into
mainfrom
dogfood-0905-fixes

Conversation

@suleimansh

Copy link
Copy Markdown
Contributor

Three fixes from the 2026-09-05 dogfood on the real daemon.

npx tickets ran a stranger's package. The tickets SKILL.md says the command is a dependency of the repository. This repository broke that rule: only packages/framework depended on the skills, so the root had no tickets or branches bin. In an agent's checkout, npx tickets fell through to the npm registry and ran tickets@0.2.2, a JIRA lookup tool, without failing. The root now depends on both skill packages. npx tickets and npx branches resolve to the checkout's own bins. A checkout without a build fails loudly on the missing dist/ instead of running someone else's tool. The daemon's PATH, which carries the main checkout's built bins, is unchanged.

The CLI tests inherited the daemon's AGENT_ID. cli.test.ts calls the CLI in-process, and the CLI reads AGENT_ID from the real environment. The daemon sets it for every agent it starts, so pnpm test in an agent run failed three tests with the agent's id as holder. The test file now drops the variable at load. The one test that needs it still sets it on purpose. Verified by removing the line and running with AGENT_ID set: 3 of 6 fail; with it, 58 of 58 pass.

Two SKILL.md phrases that the agent guessed wrong. list prints one JSON array, not an object holding one. With --ticket, <text> becomes the label of the link to the ticket; the agent passed a link and got a double-wrapped entry. Both phrases say what the code does today. The CLI usage line for list says the same.

🤖 curated · Fable 5.1, effort high

…e daemon's AGENT_ID, two SKILL.md phrases

The root depends on both skill packages, so `npx tickets` and `npx branches`
resolve to the checkout's own bins instead of falling through to the registry.
cli.test.ts drops AGENT_ID at load; the daemon sets it for every agent. SKILL.md
says `list` prints one JSON array and that `--ticket` takes the link's label.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LnZR6mRrKS1fB5GoJrkSGX
@suleimansh
suleimansh merged commit 8916dea into main Sep 7, 2026
2 checks passed
@suleimansh
suleimansh deleted the dogfood-0905-fixes branch September 7, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant