Fix SSR detection in Deno #1522
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heypiotr
commented
Apr 21, 2022
| @@ -21,7 +21,6 @@ let hasListeners = false | |||
|
|
|||
| function addEventListeners() { | |||
| hasListeners = true | |||
| if (typeof window === "undefined") return | |||
There was a problem hiding this comment.
addEventListeners is called in an effect, which makes this check redudant. But let me know if you feel it's better to leave it in.
mattgperry
approved these changes
Apr 22, 2022
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deno provides a
windowobject, which makes Framer Motion believe it's running in a browser when using Deno for SSR. They suggest checking thedocumentinstead:denoland/deno#13367
There's a few more
typeof windowchecks indist, centered aroundwindow.requestAnimationFrame. I suspect these are coming from some dependency. In my testing (SSRing www.framer.com/sites in Deno), they haven't caused any trouble, despitewindow.requestAnimationFramebeingundefined(which means if there is some code path which triggers them, it would crash).