Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: privy account abstraction #61

Open
wants to merge 6 commits into
base: draft
Choose a base branch
from

Conversation

iyansr
Copy link
Collaborator

@iyansr iyansr commented Dec 23, 2024

No description provided.

@@ -34,6 +34,9 @@
"editor.defaultFormatter": "biomejs.biome"
},
"editor.defaultFormatter": "biomejs.biome",
"editor.codeActionsOnSave": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iyansr can you deocuple lint related into another PR?
we can merge the feature first and lint later

}

const [pimlicoRpcUrl] = useState(
`https://api.pimlico.io/v2/11155111/rpc?apikey=${pimlicoApiKey}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decouple util for generating api url by chain id

Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: c1462fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@debuggingfuture debuggingfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i couldn't get it working due to the error
[useConfig must be used within WagmiConfig](https://github.com/rainbow-me/rainbowkit/issues/1304#top)

I find this on doc (to my suprise)
https://docs.privy.io/guide/react/wallets/usage/evm/wagmi/

Make sure to import WagmiProvider from @privy-io/wagmi, not wagmi

@iyansr i bumped the deps versions and opt for decorator pattern

@iyansr
Copy link
Collaborator Author

iyansr commented Jan 20, 2025

i couldn't get it working due to the error [useConfig must be used within WagmiConfig](https://github.com/rainbow-me/rainbowkit/issues/1304#top)

I find this on doc (to my suprise) https://docs.privy.io/guide/react/wallets/usage/evm/wagmi/

Make sure to import WagmiProvider from @privy-io/wagmi, not wagmi

@iyansr i bumped the deps versions and opt for decorator pattern

Checking

}: PropsWithChildren<PrivyAAContextProps>) {
const config = { ...PRIVY_CONFIG_DEFAULT, ...privyConfig };
// TODO remove chain hardcode
const pimlicoRpcUrl = generatePimlicoRpcUrl(sepolia.id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does pimlico able to support multiple chain choice?

when user try to switch chain via wagmi, are we able to pick the right rpc?

see how can we read the chains supported from wagmi

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants