-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: privy account abstraction #61
base: draft
Are you sure you want to change the base?
Conversation
.vscode/settings.json
Outdated
@@ -34,6 +34,9 @@ | |||
"editor.defaultFormatter": "biomejs.biome" | |||
}, | |||
"editor.defaultFormatter": "biomejs.biome", | |||
"editor.codeActionsOnSave": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iyansr can you deocuple lint related into another PR?
we can merge the feature first and lint later
} | ||
|
||
const [pimlicoRpcUrl] = useState( | ||
`https://api.pimlico.io/v2/11155111/rpc?apikey=${pimlicoApiKey}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decouple util for generating api url by chain id
…feat/privy-account-abstraction
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i couldn't get it working due to the error
[useConfig must be used within WagmiConfig](https://github.com/rainbow-me/rainbowkit/issues/1304#top)
I find this on doc (to my suprise)
https://docs.privy.io/guide/react/wallets/usage/evm/wagmi/
Make sure to import
WagmiProvider
from@privy-io/wagmi
, notwagmi
@iyansr i bumped the deps versions and opt for decorator pattern
Checking |
}: PropsWithChildren<PrivyAAContextProps>) { | ||
const config = { ...PRIVY_CONFIG_DEFAULT, ...privyConfig }; | ||
// TODO remove chain hardcode | ||
const pimlicoRpcUrl = generatePimlicoRpcUrl(sepolia.id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does pimlico able to support multiple chain choice?
when user try to switch chain via wagmi, are we able to pick the right rpc?
see how can we read the chains supported from wagmi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
No description provided.