Add support for providing fee per CU in Solana #451
Merged
+235
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this initial version we use a static value, later we could add an option to set it dynamically (e.g. using Priority Fee API from Helius)
Deploying kolme with
|
| Latest commit: |
b0be505
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f1e5b23.kolme.pages.dev |
| Branch Preview URL: | https://solana-fee-per-cu.kolme.pages.dev |
|
This follows https://solana.com/docs/core/fees but uses only fixed fee per CU. For dynamic priority fees we could add support for Priority Fee API from Helius https://www.helius.dev/docs/priority-fee-api or something from other node providers. Public node don't provide options like that |
psibi
reviewed
Aug 13, 2025
| @@ -58,10 +59,14 @@ impl<App: KolmeApp> Submitter<App> { | |||
| pub fn new_solana( | |||
| kolme: Kolme<App>, | |||
| keypair: kolme_solana_bridge_client::keypair::Keypair, | |||
| fee_per_cu: Option<u64>, | |||
There was a problem hiding this comment.
Instead of passing optional value, do you think we can have something like a builder pattern, where we do set_fee_per_cu instead ?
There was a problem hiding this comment.
Overall I like the idea as it probably could allow us to add a callback for fee API as well.
At the moment with only one argument that looks to be over-complication.
psibi
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this initial version we use a static value, later we could add an
option to set it dynamically (e.g. using Priority Fee API from Helius)