Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug postfix option #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hankarun
Copy link

Add debug postfix option to the cmake configuration. User can select debug postfix variable with DEBUG_POSTFIX variable.

Add debug postfix option to the cmake configuration. User can select debug postfix variable with DEBUG_POSTFIX variable.
@kotopesutility
Copy link

According to the first item from https://github.com/fpagliughi/sockpp/blob/master/CONTRIBUTING.md you have to send all PR to the develop branch:

  1. New and unstable development is done in the develop branch. Please make all pull requests against the develop branch.

@fpagliughi
Copy link
Owner

Yes, I do prefer PRs against the develop branch, especially when it has diverged significantly from master. It make merging easier, and ensures that the changes reflect the current development state. Since releases of this library are fairly slow, I like to keep master as stable as possible, and only push to it from develop as the new features are tested and settled down.

But that wouldn't prevent me from merging something small like this.

@hankarun Isn't the 'd' postfix only common on Windows systems? I don't think I've ever seen this done on Linux or other *nix systems like Mac.

And if you were to add that, how would apps that use the target be affected? Would they automatically pick up the postfix version if they were compiled for debug?

Apologies for my ignorance. I don't do much Windows programming, and haven't really seen this used before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants