Fully implement List Recordings (#133)

4 fields where missing from the query params, which are all added here
foxglove · Jan 10, 2024 · 52fa2a6 · 52fa2a6
1 parent 09c0374
commit 52fa2a6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/foxglove/cmd/recordings.go b/foxglove/cmd/recordings.go
@@ -18,6 +18,10 @@ func newListRecordingsCommand(params *baseParams) *cobra.Command {
 	var start string
 	var end string
 	var importStatus string
+	var limit int
+	var offset int
+	var sortBy string
+	var sortOrder string
 	var isJsonFormat bool
 	recordingsListCmd := &cobra.Command{
 		Use:   "list",
@@ -48,6 +52,10 @@ func newListRecordingsCommand(params *baseParams) *cobra.Command {
 					SiteID:       primarySiteID,
 					EdgeSiteID:   edgeSiteID,
 					ImportStatus: importStatus,
+					Limit:        limit,
+					Offset:       offset,
+					SortBy:       sortBy,
+					SortOrder:    sortOrder,
 				},
 				client.Recordings,
 				format,
@@ -67,6 +75,10 @@ func newListRecordingsCommand(params *baseParams) *cobra.Command {
 	recordingsListCmd.PersistentFlags().StringVarP(&primarySiteID, "site-id", "", "", "primary site ID")
 	recordingsListCmd.PersistentFlags().StringVarP(&edgeSiteID, "edge-site-id", "", "", "edge site ID")
 	recordingsListCmd.PersistentFlags().StringVarP(&importStatus, "import-status", "", "", "import status")
+	recordingsListCmd.PersistentFlags().IntVarP(&limit, "limit", "", 2000, "max number of recordings to return")
+	recordingsListCmd.PersistentFlags().IntVarP(&offset, "offset", "", 0, "number of recordings to skip")
+	recordingsListCmd.PersistentFlags().StringVarP(&sortBy, "sort-by", "", "", "sort recordings by a field")
+	recordingsListCmd.PersistentFlags().StringVarP(&sortOrder, "sort-order", "", "", "sort order: 'asc' 'desc'")
 	AddFormatFlag(recordingsListCmd, &format)
 	AddDeviceAutocompletion(recordingsListCmd, params)
 	AddJsonFlag(recordingsListCmd, &isJsonFormat)

diff --git a/foxglove/console/api.go b/foxglove/console/api.go
@@ -163,6 +163,10 @@ type RecordingsRequest struct {
 	SiteID       string `json:"site.id" form:"site.id,omitempty"`
 	EdgeSiteID   string `json:"edgeSite.id" form:"edgeSite.id,omitempty"`
 	ImportStatus string `json:"importStatus" form:"importStatus,omitempty"`
+	Limit        int    `json:"limit" form:"limit,omitempty"`
+	Offset       int    `json:"offset" form:"offset,omitempty"`
+	SortBy       string `json:"sortBy" form:"sortBy,omitempty"`
+	SortOrder    string `json:"sortOrder" form:"sortOrder,omitempty"`
 }
 
 type SiteSummary struct {