Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept empty from-address in SPF fixes foxcpp/maddy#603 #652

Closed
wants to merge 1 commit into from

Conversation

Beutlin
Copy link

@Beutlin Beutlin commented Dec 2, 2023

No description provided.

@foxcpp
Copy link
Owner

foxcpp commented Dec 21, 2023

2.4. The "MAIL FROM" Identity

SPF verifiers MUST check the "MAIL FROM" identity if a "HELO" check
either has not been performed or has not reached a definitive policy
result by applying the check_host() function to the "MAIL FROM"
identity as the .

[RFC5321] allows the reverse-path to be null (see Section 4.5.5 in
[RFC5321]). In this case, there is no explicit sender mailbox, and
such a message can be assumed to be a notification message from the
mail system itself. When the reverse-path is null, this document
defines the "MAIL FROM" identity to be the mailbox composed of the
local-part "postmaster" and the "HELO" identity (which might or might
not have been checked separately before).

RFC 7208 has this requirement for this case, in case of empty MAIL FROM it seems like it should be assumed to be equal to "postmaster@HELO-hostname-here". That is, "postmaster@" + s.msgMeta.Conn.Hostname.

foxcpp added a commit that referenced this pull request Jan 21, 2024
@foxcpp
Copy link
Owner

foxcpp commented Jan 21, 2024

Superseded by ab94e0b.

@foxcpp foxcpp closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants